XP Reloaded skin - image width, height from cp settings are being ignored. - CP DEVEL

		CP DEVEL > Projects > Hsphere Control Panel > Bug
XP Reloaded skin - image width, height from cp settings are being ignored.

XP Reloaded skin - image width, height from cp settings are being ignored.	Issue Tools

04-13-2010 05:02 AM

ghost

Administrator

XP Reloaded skin - image width, height from cp settings are being ignored.

In file extra.fn they call the logo with:

Code:

<TD class="head_hs_logo"><IMG SRC="${settings.logo_url}" ></TD>

They should add the height and width attributes:

Code:

<if settings.logo_image_width><assign logo_image_width="WIDTH=\""+settings.logo_image_width+"\""></if>
<if settings.logo_image_height><assign logo_image_height="HEIGHT=\""+settings.logo_image_height+"\""></if>
<TD class="head_hs_logo"><IMG SRC="${settings.logo_url}" ${logo_image_width} ${logo_image_height} BORDER="0" ></TD>

Also added the copyright turn off code built into the settings - corporate logo section.
Also added if you add your own logo the parallels logo on the right is hidden.

Parallels response was it was done on purpose so it wouldn't break the reloaded design. Once needs to use the same size as default parallels hsphere logo.

I dont feel that is good enough so adding at a bug.

Issue Details
Issue Type Bug Project Hsphere Control Panel Category Unknown Status Fixed by third party Priority 5 - Medium Affected Version 3.3 P1 Fixed Version (none) Users able to reproduce bug 0 Users unable to reproduce bug 0 Attachments 0 Assigned Users (none) Tags (none)

04-23-2010 03:44 PM

ghost

Administrator

Below is the fixed file. You can copy to custom templates folder for it to be permanent of you can overwrite the default one but on next update it will be gone. Below is the instructions for both.

Method1 (stays on upgrades):
mkdir /hsphere/local/home/cpanel/shiva/custom/templates/reloaded
cd /hsphere/local/home/cpanel/shiva/custom/templates/reloaded
wget http://addons.hspheretemplates.com/bugfixes/extra.zip
unzip extra.zip

mkdir /hsphere/local/home/cpanel/shiva/custom/templates/reloaded/signup
cd /hsphere/local/home/cpanel/shiva/custom/templates/reloaded/signup
wget http://addons.hspheretemplates.com/b...ded_bottom.zip
unzip reloaded_bottom.zip

or

Method2 (removed on upgrades):
cp /hsphere/local/home/cpanel/shiva/shiva-templates/reloaded/extra.fn /hsphere/local/home/cpanel/shiva/shiva-templates/reloaded/extra.fn.backup
cd /hsphere/local/home/cpanel/shiva/shiva-templates/reloaded
wget http://addons.hspheretemplates.com/bugfixes/extra.zip
unzip extra.zip

cp /hsphere/local/home/cpanel/shiva/shiva-templates/reloaded/signup/signup_bottom.html /hsphere/local/home/cpanel/shiva/shiva-templates/reloaded/signup/signup_bottom.html.backup
cd /hsphere/local/home/cpanel/shiva/custom/templates/reloaded/signup
wget http://addons.hspheretemplates.com/bugfixes/reloaded_bottom.zip
unzip reloaded_bottom.zip

06-18-2010 03:21 PM

Blake@Parallels Blake@Parallels is offline

Junior Member

This is filed internally as TP#21150.

07-01-2010 09:31 AM

Blake@Parallels Blake@Parallels is offline

Junior Member

Informed development of above customer-provided fix.

Issue Tools
Subscribe to this issue

All times are GMT -5. The time now is 02:26 PM.